Skip to content

fix: fix wild pointer issue when screen switching #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
18202781743 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: fix wild pointer issue when screen switching #1450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions panels/dock/dockpanel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand All @@ -8,7 +8,8 @@
#include "dsglobal.h"
#include "constants.h"

#include <QDBusContext>

Check warning on line 11 in panels/dock/dockpanel.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QDBusContext> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QPointer>

Check warning on line 12 in panels/dock/dockpanel.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QPointer> not found. Please note: Cppcheck does not need standard library headers to get proper results.

namespace dock {
class DockHelper;
Expand Down Expand Up @@ -138,7 +139,7 @@
ColorTheme m_theme;
HideState m_hideState;
DockHelper* m_helper;
QScreen *m_dockScreen;
QPointer<QScreen> m_dockScreen;
LoadTrayPlugins *m_loadTrayPlugins;
bool m_compositorReady;
bool m_launcherShown;
Expand Down