Skip to content

fix: remove invalid DBus error message sending #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Feb 11, 2026
Merged

fix: remove invalid DBus error message sending #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions panels/notification/server/dbusadaptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand Down Expand Up @@ -32,10 +32,7 @@ uint DbusAdaptor::Notify(const QString &appName, uint replacesId, const QString
{
uint id = manager()->Notify(appName, replacesId, appIcon, summary, body, actions, hints, expireTimeout);
if (id == 0) {
QDBusError error(QDBusError::InternalError, "Notify failed.");
QDBusMessage reply = QDBusMessage::createError(error);

QDBusConnection::sessionBus().send(reply);
qWarning(notifyLog) << "Notify failed for app:" << appName;
}

return id;
Expand Down Expand Up @@ -76,10 +73,7 @@ uint DDENotificationDbusAdaptor::Notify(const QString &appName, uint replacesId,
{
uint id = manager()->Notify(appName, replacesId, appIcon, summary, body, actions, hints, expireTimeout);
if (id == 0) {
QDBusError error(QDBusError::InternalError, "Notify failed.");
QDBusMessage reply = QDBusMessage::createError(error);

QDBusConnection::sessionBus().send(reply);
qWarning(notifyLog) << "Notify failed for app:" << appName;
}

return id;
Expand Down