refactor: optimize build system security flags#40
Merged
BLumia merged 1 commit intolinuxdeepin:masterfrom Jul 3, 2025
Merged
Conversation
1. Removed redundant security flags from CMakeLists.txt since they are now handled by debian/rules
2. Added comprehensive security hardening flags in debian/rules using DEB_BUILD_MAINT_OPTIONS
3. Standardized compiler flag handling across all CMakeLists.txt files by using ${CMAKE_CXX_FLAGS} consistently
4. Kept -g flag for debugging but moved it to be appended to existing flags
The changes centralize security flag management in the Debian build system rather than having them scattered across multiple CMake files. This makes the build configuration more maintainable and consistent with Debian packaging standards.
refactor: 优化构建系统安全标志
1. 从 CMakeLists.txt 中移除冗余的安全标志,现在由 debian/rules 统一处理
2. 在 debian/rules 中使用 DEB_BUILD_MAINT_OPTIONS 添加全面的安全加固标志
3. 通过统一使用 ${CMAKE_CXX_FLAGS} 标准化所有 CMakeLists.txt 文件中的编 译器标志处理
4. 保留 -g 调试标志但改为追加到现有标志中
这些变更将安全标志管理集中到 Debian 构建系统中,而不是分散在多个 CMake
文件中,使构建配置更易维护且符合 Debian 打包标准。
deepin pr auto review代码审查意见如下: CMakeLists.txt 文件修改修改建议
具体修改
debian/rules 文件修改修改建议
具体修改
代码质量
代码性能
代码安全
总体来说,这些修改有助于提高代码的质量、性能和安全性。 |
18202781743
approved these changes
Jul 3, 2025
BLumia
approved these changes
Jul 3, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes centralize security flag management in the Debian build system rather than having them scattered across multiple CMake files. This makes the build configuration more maintainable and consistent with Debian packaging standards.
refactor: 优化构建系统安全标志
这些变更将安全标志管理集中到 Debian 构建系统中,而不是分散在多个 CMake
文件中,使构建配置更易维护且符合 Debian 打包标准。