Fixed an issue that key configs are not read correctly.#14
Open
soarqin wants to merge 1 commit intolimoka:masterfrom
Open
Fixed an issue that key configs are not read correctly.#14soarqin wants to merge 1 commit intolimoka:masterfrom
soarqin wants to merge 1 commit intolimoka:masterfrom
Conversation
soarqin
force-pushed
the
keybind_sys_fix
branch
from
8bffc98 to
5ba9dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GameOption.InitKeys()is inside call-chain inGameOption.ImportXML()so that loaded key configs in prefix patch are reset.This PR fixes this issue by skipping
GameOption.InitKeys()(We initialized key lists in prefix patch already).