Skip to content

feat: sort ScMap entries by key in Scv.toMap following Soroban runtime ordering#766

Open
overcat wants to merge 4 commits intomasterfrom
feat/sort-scmap-entries-by-key
Open

feat: sort ScMap entries by key in Scv.toMap following Soroban runtime ordering#766
overcat wants to merge 4 commits intomasterfrom
feat/sort-scmap-entries-by-key

Conversation

@overcat
Copy link
Member

@overcat overcat commented Mar 4, 2026

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 93.01075% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.41%. Comparing base (64abf03) to head (ec0ad0c).

Files with missing lines Patch % Lines
...main/java/org/stellar/sdk/scval/ScvComparator.java 93.47% 7 Missing and 5 partials ⚠️
src/main/java/org/stellar/sdk/scval/Scv.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #766      +/-   ##
============================================
+ Coverage     81.01%   81.41%   +0.39%     
- Complexity     1417     1478      +61     
============================================
  Files           218      219       +1     
  Lines          5400     5586     +186     
  Branches        540      570      +30     
============================================
+ Hits           4375     4548     +173     
- Misses          721      729       +8     
- Partials        304      309       +5     
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/scval/ScvMap.java 70.58% <100.00%> (+1.83%) ⬆️
src/main/java/org/stellar/sdk/scval/Scv.java 95.91% <0.00%> (-2.00%) ⬇️
...main/java/org/stellar/sdk/scval/ScvComparator.java 93.47% <93.47%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@overcat overcat force-pushed the feat/sort-scmap-entries-by-key branch 2 times, most recently from 9e463d4 to c8333cc Compare March 4, 2026 02:47
@overcat overcat force-pushed the feat/sort-scmap-entries-by-key branch from aa519e2 to 2f6a820 Compare March 4, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant