Skip to content

chore: remove unused import and unexpected cfg warnings #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
enigbe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused import and unexpected cfg warnings #89

enigbe wants to merge 1 commit into from

Conversation

@enigbe
Copy link
Contributor

@enigbe enigbe commented Jan 23, 2026

De-clutters stdout by removing these warnings

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 23, 2026 •
edited
Loading

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull
tnull reviewed Jan 23, 2026
View reviewed changes
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 26, 2026

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@enigbe enigbe force-pushed the 2026-01-chore-remove-unused-import-unexpected-cfg branch from 135e619 to 0a81ba6 Compare January 26, 2026 05:56
tankyleo
tankyleo reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also go ahead and delete the chore: prefix, start directly with the actual commit message thank you !

rust/api/Cargo.toml Outdated
_test_utils =["rand"]

[lints.rust]
unexpected_cfgs = { level = "forbid", check-cfg = ['cfg(genproto)'] }
Copy link
Contributor

@tankyleo tankyleo Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on master, and add this to the workspace Cargo.toml ? Then here we can do a

[lints]
workspace = true

just like in rust-lightning

Copy link
Contributor Author

@enigbe enigbe Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@enigbe enigbe force-pushed the 2026-01-chore-remove-unused-import-unexpected-cfg branch 2 times, most recently from 0a81ba6 to f94a627 Compare January 27, 2026 06:54
@enigbe
Copy link
Contributor Author

enigbe commented Jan 27, 2026

Thanks for the review @tankyleo
I have addressed the pending comments on this.

tankyleo
tankyleo reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Please capitalize the first word of the commit message to keep things consistent thank you. We'll merge this right after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull left review comments

@tankyleo tankyleo tankyleo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enigbe @ldk-reviews-bot @tnull @tankyleo