Default to anchors and remove automatic channel acceptance #4354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `negotiate_anchors_zero_fee_htlc_tx` default to true and removes the `manually_accept_inbound_channels` config option. This will require users to manually have to accept all inbound channels.
|
👋 Hi! I see this is a draft PR. |
Collaborator
Hmm, can you ask claude to change those to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4337
Changes
negotiate_anchors_zero_fee_htlc_txdefault to true and removes themanually_accept_inbound_channelsconfig option.TODO:
negotiate_anchors_zero_fee_htlc_txdefault to true in the tests causes +100 test failures