Add basic CLAUDE.md file

[tnull]

We add a basic CLAUDE.md file pointing it to some workspace specifics (in particular running cargo fmt on 1.75.0 MSRV, and using ./ci/ci-tests.sh to run tests).

[ldk-reviews-bot]

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[tnull]

@joostjager @TheBlueMatt Anything else that you deem worthy to add?

[TheBlueMatt]

Nothing comes to mind, we can definitely iterate on it.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.09%. Comparing base (9e91b2e) to head (ecf8c05).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4352   +/-   ##
=======================================
  Coverage   86.08%   86.09%           
=======================================
  Files         156      156           
  Lines      102428   102428           
  Branches   102428   102428           
=======================================
+ Hits        88179    88181    +2     
+ Misses      11754    11753    -1     
+ Partials     2495     2494    -1     

Flag	Coverage Δ
tests	86.09% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[joostjager]

I don't think this is always practical when working on draft branches?

[vincenzopalazzo]

probably it is possible to specify it in a way that we can ask claude to run the CI checks? But do not assume to run it always?

On mine I have

### When to run CI checks
- When explicitly asked (e.g., "run CI", "check CI", "verify commits")
- Before creating a PR (if requested)
- After fixing CI-related issues

[tnull]

I don't think this is always practical when working on draft branches?

Hmm, but ensuring tests pass before committing is kinda important, no? And in my experience it will allow Claude to catch a lot of bugs? Any suggestion for a good replacement, maybe cargo test, which should be considerably faster, even if it doesn't catch everything?

[joostjager]

Perhaps it can be:

Always run tests before committing, unless the commit message contains "WIP" or "draft" (case-insensitive).

[tnull]

Perhaps it can be:

Always run tests before committing, unless the commit message contains "WIP" or "draft" (case-insensitive).

That seems tailored to your specific workflow. Maybe you want to put that in your .claude.local.md override instead?

[joostjager]

I can try to override the testing behavior.

It isn't my workflow to prepend the commit titles, but I could adopt that as the workflow potentially.

Let's go with what you have and see how it works out, and adapt if necessary

[joostjager]

Specify how this should be disclosed, maybe a standard sentence to add for consistency?

[TheBlueMatt]

We should consistently require it disclose itself as HAL 9000 😂

[tnull]

Specify how this should be disclosed, maybe a standard sentence to add for consistency?

I don't know - do you have a specific example in mind? Otherwise above instructions worked pretty well for me so far.

[joostjager]

Maybe just put what it produced for you in here? Or just specifiy that it should use co-authored-by

[tnull]

Maybe just put what it produced for you in here? Or just specifiy that it should use co-authored-by

Done:

diff --git a/CLAUDE.md b/CLAUDE.md
index 51bbe1d90..611322c12 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -14,4 +14,4 @@ See [README.md](README.md) for the workspace layout and [ARCH.md](ARCH.md) for s
 - Run `cargo +1.75.0 fmt --all` after every code change
 - Never add new dependencies unless explicitly requested
-- Please always disclose the use of any AI tools in commit messages and PR descriptions
+- Please always disclose the use of any AI tools in commit messages and PR descriptions using a `Co-Authored-By:` line.
 - When adding new `.rs` files, please ensure to always add the licensing header as found, e.g., in `lightning/src/lib.rs` and other files.