Defer ChainMonitor updates and persistence to flush() #4351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes `ChainMonitor` to queue monitor operations instead of applying them immediately. When `watch_channel` or `update_channel` is called, the operation is added to a pending queue and `ChannelMonitorUpdateStatus::InProgress` is returned. The actual monitor insertion/update and persistence happens when `flush()` is called. This enables proper ordering of persistence: the `ChannelManager` can be persisted first, then `flush()` is called to persist the monitors. This ensures that on restart, the `ChannelManager` state is never ahead of the monitor state. The background processor is updated to: 1. Capture `pending_monitor_operation_count()` before persisting ChannelManager 2. After ChannelManager persistence completes, call `flush()` with that count 3. On shutdown, flush all remaining pending operations after final persistence Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
👋 Hi! I see this is a draft PR. |
Contributor
Author
|
Closing this PR as #4345 seems to be the easiest way to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
ChainMonitorto queue monitor operations instead of applying them immediately. Whenwatch_channelorupdate_channelis called, the operation is added to a pending queue andChannelMonitorUpdateStatus::InProgressis returned. The actual monitor insertion/update and persistence happens whenflush()is called.This enables proper ordering of persistence: the
ChannelManagercan be persisted first, thenflush()is called to persist the monitors. This ensures that on restart, theChannelManagerstate is never ahead of the monitor state.The background processor is updated to:
pending_monitor_operation_count()before persisting ChannelManagerflush()with that count