Follow-ups for #3979 #4028
Merged
Follow-ups for #3979 #4028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing a splice_ack, the debug_assert on the range of our_funding_contribution should account for values that are for both positive (splice-in) and negative (splice-out).
How fees are paid for in a SpliceContribution depends on whether it is a SpliceIn or SpliceOut. Include this in its docs for clarification.
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4028 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 176 176
Lines 127944 127944
Branches 127944 127944
=======================================
+ Hits 113564 113568 +4
+ Misses 11808 11799 -9
- Partials 2572 2577 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses outstanding comments from #3979.