Skip to content

Bump test dependencies and reorganize Docker files#869

Merged
tnull merged 1 commit intolightningdevkit:mainfrom
febyeji:upgrade-test-deps
Apr 6, 2026
Merged

Bump test dependencies and reorganize Docker files#869
tnull merged 1 commit intolightningdevkit:mainfrom
febyeji:upgrade-test-deps

Conversation

@febyeji
Copy link
Copy Markdown
Contributor

@febyeji febyeji commented Apr 3, 2026

Test dependency updates:

  • bitcoind/corepc-node: 27.2 → 29.0 (corepc-node 0.10.0 → 0.10.1)
  • lnd_grpc_rust: 2.10.0 → 2.14.0
  • Docker CLN: v23.08 → v25.12.1 (elementsproject/lightningd)
  • Docker LND: v0.18.5-beta → v0.20.1-beta
  • Docker bitcoind (CLN/LND compose): 27.2 → 29.1
  • Download script: bitcoind 29.0 with updated SHA256 hashes

Organization:

Closes #855 and Prerequisite for #839 (interop-test-harness).

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 3, 2026

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from tnull April 3, 2026 15:48
@ldk-reviews-bot
Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Copy link
Copy Markdown
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  • bitcoind/corepc-node: 27.2 → 29.0 (corepc-node 0.10.0 → 0.10.1)

Hmm, remind me, why can't we bump to v30 or even v31 directly? Was it something to do with LND not being compatible yet? If so, is the issue already fixed on their main and could we intermittently opt to use a more recent (e.g. 'daily-testing') image to work around this?

@febyeji
Copy link
Copy Markdown
Contributor Author

febyeji commented Apr 6, 2026

What I found is that corepc-node 0.10.1 doesn't have a 30_0 feature flag yet, and since our tests use it to manage the regtest bitcoind instance, I went with 29.0.

Test dependency updates:
- bitcoind/corepc-node: 27.2 → 29.0 (corepc-node 0.10.0 → 0.10.1)
- lnd_grpc_rust: 2.10.0 → 2.14.0
- Docker CLN: v23.08 → v25.12.1 (elementsproject/lightningd)
- Docker LND: v0.18.5-beta → v0.20.1-beta
- Docker bitcoind (CLN/LND compose): 27.2 → 29.1
- Download script: bitcoind 29.0 with updated SHA256 hashes

CI fixes for bitcoind 29.0:
- Cache key: add version to invalidate stale 27.2 cache
- mkdir -p: needed when bitcoind cache misses but electrs cache hits

CLN v25 compatibility:
- Remove --experimental-anchors (deprecated in v25, causes BROKEN startup)
- Add sleep before close_channel (monitor update timing with v25+)

Organization:
- Move docker-compose files to tests/docker/ (resolves lightningdevkit#855)

Closes lightningdevkit#855
@febyeji febyeji force-pushed the upgrade-test-deps branch from eef5142 to 1f5e920 Compare April 6, 2026 09:56
@tnull
Copy link
Copy Markdown
Collaborator

tnull commented Apr 6, 2026

What I found is that corepc-node 0.10.1 doesn't have a 30_0 feature flag yet, and since our tests use it to manage the regtest bitcoind instance, I went with 29.0.

Ah, I thought they had shipped v30 support yet. Makes sense then!

@tnull tnull merged commit ee6c997 into lightningdevkit:main Apr 6, 2026
18 of 19 checks passed
Copy link
Copy Markdown
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, whoops, after merging I realized this might have missed ./docker-compose.yml? @febyeji Mind just doing that still in a quick follow-up?

@febyeji
Copy link
Copy Markdown
Contributor Author

febyeji commented Apr 6, 2026

Okay I will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move interop test Docker files to tests/docker/

3 participants