feat: added WalletConnect integration for improve tests speed#361
Open
feat: added WalletConnect integration for improve tests speed#361
Conversation
…etConnect handling
…etConnect handling
…n void and enhance transaction validation
…n void and enhance transaction validation
…tion cancellation
…tion cancellation
…ity and maintainability
Vorobeyko
changed the title
…esponse structure
itaven
reviewed
Mar 5, 2026
itaven
reviewed
Mar 5, 2026
itaven
reviewed
Mar 5, 2026
itaven
reviewed
Mar 5, 2026
packages/wallets/src/walletConnect/components/requestManager.ts
Outdated
Show resolved
Hide resolved
itaven
reviewed
Mar 5, 2026
itaven
reviewed
Mar 5, 2026
itaven
reviewed
Mar 5, 2026
itaven
reviewed
Mar 5, 2026
jake4take
changed the title
jake4take
reviewed
Mar 17, 2026
| extensionPage: extensionWalletPage, | ||
| extensionPage: buildExtensionWalletPage(), | ||
| walletConfig: this.options.walletConfig, | ||
| standConfig: { |
Contributor
There was a problem hiding this comment.
Maybe we can create a standConfig object before the switch..case and reuse it here and on line 192
| 1946: soneiumMinato as Chain, | ||
| 130: unichain as Chain, | ||
| 1301: unichainSepolia as Chain, | ||
| }; |
Contributor
There was a problem hiding this comment.
Need to add more supported networks for ETH widget testing (qaseId=3596):
- zkSync Era
- Arbitrum
- Polygon PoS
- Base
- BNB Chain
- Linea
- Mantle
- Scroll
- Mode chain
- Zircuit Chain
- Lisk
| } | ||
|
|
||
| export type WalletConnectType = | ||
| | WalletConnectTypes.WC |
Contributor
There was a problem hiding this comment.
Wdyt to rename WC -> WC+EOA?
| LATEST_STABLE_DOWNLOAD_LINK?: string; // Link to stable wallet extension version for test (optional) | ||
| EXTENSION_START_PATH: string; // Start path for wallet setup | ||
| EXTENSION_START_PATH?: string; // Start path for wallet setup | ||
| // Only for WalletConnect wallets via API @walletconnect/sign-client |
Contributor
There was a problem hiding this comment.
// Only for the WC_SDK ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.