Skip to content

feat!: remove obsolete static methods#385

Merged
lduchosal merged 3 commits intomasterfrom
feat/v4-remove-obsoletes
Mar 7, 2026
Merged

feat!: remove obsolete static methods#385
lduchosal merged 3 commits intomasterfrom
feat/v4-remove-obsoletes

Conversation

@lduchosal
Copy link
Owner

Summary

  • Restore [Obsolete] attributes on deprecated static methods
  • Remove all obsolete static methods that have instance equivalents:
    Contains, Overlap, Print, Subnet, TrySubnet, Supernet, TrySupernet, IsIANAReserved(IPNetwork2)
  • Remove FilterEnum enum and ListIPAddress(FilterEnum) overload
  • Remove 20 corresponding test methods
  • Add .DS_Store to .gitignore

Test plan

  • All 1298 tests pass
  • Build with 0 warnings, 0 errors

🤖 Generated with Claude Code

lduchosal and others added 3 commits March 7, 2026 21:31
Restore [Obsolete] on static methods (Contains, Overlap, Print,
Subnet, TrySubnet, Supernet, TrySupernet, IsIANAReserved) and
on FilterEnum and ListIPAddress(FilterEnum) before removing them.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove deprecated static methods that have instance equivalents:
- Contains(IPNetwork2, IPAddress), Contains(IPNetwork2, IPNetwork2)
- Overlap(IPNetwork2, IPNetwork2)
- Print(IPNetwork2)
- Subnet(IPNetwork2, byte), TrySubnet(IPNetwork2, byte, out)
- Supernet(IPNetwork2, IPNetwork2), TrySupernet(IPNetwork2, IPNetwork2, out)
- IsIANAReserved(IPNetwork2)
- FilterEnum enum and ListIPAddress(FilterEnum)

Remove corresponding tests (20 test methods).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@lduchosal lduchosal merged commit ec127fb into master Mar 7, 2026
9 of 11 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22806802945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 92.403%

Totals Coverage Status
Change from base Build 885: -0.3%
Covered Lines: 1964
Relevant Lines: 2117

💛 - Coveralls

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants