Merged
Conversation
Rename parameter `sanitanize` to `sanitize` in Parse and TryParse methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BREAKING CHANGE: netstandard2.0 is no longer supported. Remove System.Memory package references (no longer needed). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove [Obsolete] from static methods (Subnet, TrySubnet, Supernet, TrySupernet, Print, Contains, Overlap, IsIANAReserved) and FilterEnum. Remove static ListIPAddress(IPNetwork2) which is no longer needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable <Nullable>enable</Nullable> with TreatWarningsAsErrors. Add [NotNullWhen(true)] to all TryParse, TrySubnet, TrySupernet, TrySubtract, TryWideSubnet, TryParseRange, and TryToNetmask methods. Add nullable annotations to all public API parameters and return types. Refactor Parse methods to use if(!InternalParse) pattern for proper null flow analysis, eliminating most null-forgiving (!) operators. BREAKING CHANGE: nullable annotations change API surface for consumers using nullable reference types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable <Nullable>enable</Nullable> with TreatWarningsAsErrors. Add [NotNullWhen(true)] to all TryParse, TrySubnet, TrySupernet, TrySubtract, TryWideSubnet, TryParseRange, and TryToNetmask methods. Add nullable annotations to all public API parameters and return types. Refactor Parse methods to use if(!InternalParse) pattern for proper null flow analysis, eliminating most null-forgiving (!) operators. BREAKING CHANGE: nullable annotations change API surface for consumers using nullable reference types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TryParseCidr now has [NotNullWhen(true)], so (byte)cidr is sufficient. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ArgumentException constructors expect (message, paramName) but nameof(param) was being passed as the message argument. Add descriptive messages and pass parameter names in the correct position. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 881Details
💛 - Coveralls |
- IDE0041: use pattern matching `is null` instead of `ReferenceEquals` - IDE0056: use index-from-end operator `[^1]` instead of `[.Length - 1]` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move setup code (variable declarations, Parse calls) outside Assert.ThrowsExactly lambdas, keeping only the throwing statement inside. Also remove obsolete #pragma warning disable/restore 0618. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use SHA256.HashData() on .NET 5+ targets, fallback to SHA256.Create().ComputeHash() on netstandard2.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add assertions to 11 test methods that had no Assert calls: examples, static method tests, and serialization benchmarks. Also remove obsolete #pragma warning disable/restore 0618. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- CA1510: use ArgumentNullException.ThrowIfNull on .NET 5+ - CA1512: use ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual on .NET 5+ - CA1847: use string.Contains(char) instead of string.Contains(string) - SA1507: remove multiple consecutive blank lines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Revert ThrowIfNull/ThrowIfGreaterThanOrEqual conditional blocks back to simple if/throw to fix code coverage on new code. Keep #if only for SHA256.HashData (real API difference). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Owner
Author
|
mergeing version 4.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.