Just some fixes for some minor warnings.#8
Open
jivadevoe wants to merge 5 commits intoldandersen:masterfrom
Open
Just some fixes for some minor warnings.#8jivadevoe wants to merge 5 commits intoldandersen:masterfrom
jivadevoe wants to merge 5 commits intoldandersen:masterfrom
Conversation
Author
|
Just adding another fix for another warning. |
…module, but maybe you don't like submodules... so fine. :)
Author
|
And another warning fixed (sort of). This one, you're missing a method that is apparently part of another category. I found a category that fits the bill at https://github.com/nicklockwood/Base64.git so, I added the import and added a comment that suggests where to get the category from. Arguably, if you're going to rely on a third-party addition, you should probably include that as a submodule of your module. However, maybe that doesn't fit the way that you like to organize your repos, so this is another way to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.