fix: hmr for inline use directive extracted virtual modules#356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual modules extracted by
use-directive-inlinewere not invalidated on file change in the client environment. Vite 8's module graph stores client-env virtual modules under root-relative paths, but the file watcher fires with absolute paths, sogetModulesByFile()never found them during HMR.Added a
hotUpdatehook that tracks virtual module ids per source file, looks them up viagetModuleById(), and eagerly invalidates them so stale transforms are cleared even if a downstream plugin discards the modules from the HMR update list.