Propositional Logic Response Area#7
Open
ashwin6-dev wants to merge 20 commits intolambda-feedback:mainfrom
Open
Propositional Logic Response Area#7ashwin6-dev wants to merge 20 commits intolambda-feedback:mainfrom
ashwin6-dev wants to merge 20 commits intolambda-feedback:mainfrom
Conversation
…plemented in evaluation_function)
…nge, full stringify or partial stringify
m-messer
reviewed
Mar 3, 2026
Member
m-messer
left a comment
m-messer
left a comment
There was a problem hiding this comment.
Thanks for your work on this! I've add a few minor comments, and there is a little git cleanup that would be helpful to sort.
Member
There was a problem hiding this comment.
Should this be commited as a change?
Member
There was a problem hiding this comment.
Why was this workaround necessary? This would be good to feedback.
| import { SandboxResponseAreaTub } from './types/Sandbox/index' | ||
|
|
||
| // Create a QueryClient instance | ||
| const queryClient = new QueryClient({ |
Member
There was a problem hiding this comment.
What is the query client used for?
HongleiGu
added a commit
to HongleiGu/FSA-response-area-sandbox
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check
README.mdwithin thePropositionalLogicfolder for a short description of what this response area contains.Key External Changes
Some changes were made outside the
PropositionalLogicfolder.src/externals/styles/fonts.tsx- wasexternals/styles/fonts.tsx (1:37): "Roboto" is not exported by "node_modules/next/font/google/index.js"error with the original file. Current file injects Google Fonts CSS at runtime.src/sandbox-component.tsx- added a query client provider wrapper. Had aError: No QueryClient set, use QueryClientProvider to set onein the brower console otherwise. I think this is due to the fact this response area uses OmniInput.OmniInput Preview Issue To Look At
Currently, preview doesn't show anything. I changed the backend to return a fixed dummy value for now, but still the preview doesn't show anything, which makes me believe there is an issue in the frontend.
When hand drawing the input, there is a console error saying
Input processing error (draw): TypeError: fetchData(...) is not a function. Typing the input doesn't have this error, but still the preview is empty.In
externals/api/fetcher.ts,fetchDatareturnsnull, which I think is the issue, but I do not know how I should go from there.Other response areas that use OmniInput display previews fine in the sandbox.