Refactor for cross platform, add ida-cmake support, fix dialog scaling#13
Open
camden-smallwood wants to merge 1 commit intokweatherman:masterfrom
Open
Refactor for cross platform, add ida-cmake support, fix dialog scaling#13camden-smallwood wants to merge 1 commit intokweatherman:masterfrom
camden-smallwood wants to merge 1 commit intokweatherman:masterfrom
Conversation
…d windows testing)
Owner
|
Thanks for doing this. I did an initial review of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor to make class informer cross platform, add support for ida-cmake, and fix dialog scaling to be based on content size. Currently I have only implemented ida-cmake support for macOS, but adding linux and windows support should just be a matter of extending the CMakeLists.txt and shouldn't be too bad.