[Store] Add generic batched metadata-backed buffer fetch#1834
Open
zxpdemonio wants to merge 4 commits intokvcache-ai:mainfrom
Open
[Store] Add generic batched metadata-backed buffer fetch#1834zxpdemonio wants to merge 4 commits intokvcache-ai:mainfrom
zxpdemonio wants to merge 4 commits intokvcache-ai:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a two-step read optimization for batched buffer operations in the Mooncake Store, allowing callers to reuse metadata and avoid redundant lookups. Key changes include the addition of batch_query and batch_get_buffer_with_query_results to both DummyClient and RealClient, along with RPC utilities for serializing query results and a centralized RPC service registration. The implementation handles hot cache integration and ensures that expired leases are rejected. A new test suite, batch_query_buffer_fetch_test.cpp, has been added to verify these flows. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For batched reads, upper-layer components may first fetch object metadata for a group of keys and keep the results in a query cache. Before this change, the Mooncake Store standalone client path could not directly reuse those cached query results for
get_buffer-style reads, so it had to issue another metadata lookup before starting data transfer.This meant query cache could not be effectively applied to this path, and batched reads paid an unnecessary extra metadata round trip.
This PR introduces the generic Mooncake Store primitives needed to support query-cache-backed batched buffer fetches, without tying the implementation to any Engram-specific logic. To achieve that, we:
Module
mooncake-transfer-engine)mooncake-store)mooncake-ep)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-pg)mooncake-rl)Type of Change
How Has This Been Tested?
Ran the following tests:
ctest --output-on-failure -R '^(dummy_client_get_buffer_test|batch_query_buffer_fetch_test)$'Both tests passed.
Checklist
./scripts/code_format.shbefore submitting.