Component profiling#95
Open
kunitoki wants to merge 10 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 73.58% 73.76% +0.17%
==========================================
Files 577 581 +4
Lines 56826 57237 +411
==========================================
+ Hits 41818 42221 +403
- Misses 15008 15016 +8
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cf65886 to
c055690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a built-in component paint profiling system to the YUP UI framework, allowing developers to measure and analyze the rendering performance of individual components. It adds comprehensive API support, a detailed user guide, and integrates profiling into the example app. Additionally, it improves keyboard focus handling by making it more configurable and robust.
The most important changes are:
Component Paint Profiling System:
Componentclass, including methods to enable/disable profiling, access and reset statistics, and retrieve profiling names. Added all necessary infrastructure for collecting, storing, and summarizing per-component paint timings, guarded by theYUP_ENABLE_COMPONENT_PAINT_PROFILINGflag. [1] [2]docs/Profiling Component Paint.md, explaining how to enable, use, and interpret the new profiling system.YUP_ENABLE_COMPONENT_PAINT_PROFILING=1in its CMake configuration.PaintProfilerDemoto the example app to showcase the profiling system in action. [1] [2]Keyboard Focus Handling Improvements:
Componentfor configuring and querying keyboard focus behavior (setWantsKeyboardFocus,getWantsKeyboardFocus,setClickingGrabFocus,getClickingGrabFocus). Clicking now walks up the parent chain to find a focusable component, and this logic is encapsulated inhandleKeyboardFocusFromClick. [1] [2] [3] [4] [5]These changes collectively provide powerful new tools for diagnosing UI performance issues and improve the flexibility of keyboard focus management.