Skip to content

Add support for sqlite3#94

Merged
kunitoki merged 6 commits into
mainfrom
dev/sqlite3
May 19, 2026
Merged

Add support for sqlite3#94
kunitoki merged 6 commits into
mainfrom
dev/sqlite3

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

This pull request introduces support for the SQLite3 database library as a new optional module in the codebase. The changes add the SQLite3 source and header files, update build configurations to recognize the new module, and ensure conditional inclusion of SQLite3-related code throughout the project.

SQLite3 module integration:

  • Added new files sqlite3_library.c and sqlite3_library.h under thirdparty/sqlite3_library, including module metadata and licensing information, and set up the inclusion of the SQLite3 amalgamated source (sqlite3.c) and header (sqlite3.h). [1] [2]
  • Updated the build configuration in tests/CMakeLists.txt to include sqlite3_library as a target module.

Conditional inclusion and usage:

  • Modified yup_core.h and yup_core.cpp to conditionally include the SQLite3 module headers and implementation files when YUP_MODULE_AVAILABLE_sqlite3_library is defined, ensuring the codebase only includes SQLite3 support if the module is available. [1] [2]

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 87.19723% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.16%. Comparing base (0f4a513) to head (494c234).

Files with missing lines Patch % Lines
modules/yup_core/database/yup_SqliteDatabase.cpp 86.97% 34 Missing ⚠️
modules/yup_core/database/yup_SqliteDatabase.h 89.28% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   73.09%   73.16%   +0.06%     
==========================================
  Files         571      573       +2     
  Lines       56051    56342     +291     
==========================================
+ Hits        40971    41223     +252     
- Misses      15080    15119      +39     
Files with missing lines Coverage Δ
modules/yup_core/yup_core.cpp 100.00% <ø> (ø)
modules/yup_core/database/yup_SqliteDatabase.h 89.28% <89.28%> (ø)
modules/yup_core/database/yup_SqliteDatabase.cpp 86.97% <86.97%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4a513...494c234. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit 901f930 into main May 19, 2026
39 checks passed
@kunitoki kunitoki deleted the dev/sqlite3 branch May 19, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant