Fix flaky KubernetesInformerCreatorTest on Windows due to shared semaphore race condition#4603
Draft
Copilot wants to merge 2 commits intodependabot/maven/software.amazon.awssdk-sts-2.41.32from
Conversation
…I failure Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for Java 21.0.x Maven Test
Fix flaky KubernetesInformerCreatorTest on Windows due to shared semaphore race condition
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KubernetesInformerCreatorTest.informerInjectionfails on Windows because both the pod and configmap watch stubs shared a singlewatchCountsemaphore. On Windows, the pod informer can complete LIST→WATCH, receive the empty{}response, and immediately loop back to fire a second WATCH — all before the configmap informer makes its first WATCH request. Two pod-watch firings then satisfywatchCount.acquire(2), letting the test advance toverify()before the configmap watch ever happens.Changes
CountDownLatch(1)instead of sharedSemaphore: replacedgetCount/watchCount(shared across both informers) with four independent latches —podGetLatch,podWatchLatch,configMapGetLatch,configMapWatchLatch— each wired to its own stubCountDownLatch.countDown()is a no-op once at zero, so repeated firings from one informer cannot accidentally satisfy another informer's gateCountRequestAction: switched fromSemaphore.release()toCountDownLatch.countDown()Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.