chore(inline-edit): added info about validation in FormGroup (#DS-4802)#1429
Merged
chore(inline-edit): added info about validation in FormGroup (#DS-4802)#1429
Conversation
|
Visit the preview URL for this PR (updated for commit 8478460): https://koobiq-next--prs-1429-qi2wsjpc.web.app (expires Tue, 24 Mar 2026 09:40:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
lskramarov
approved these changes
Mar 19, 2026
artembelik
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a callout to the Inline Edit documentation about using
kbqDisableLegacyValidationDirectiveProviderinside forms.When Inline Edit is placed inside a
FormGroup,KbqValidateDirectivewaits for form submission to trigger validation. This means the component never becomes invalid on its own, and users see no validation errors. AddingkbqDisableLegacyValidationDirectiveProviderto providers disables this behavior and lets validation work as expected.Press for description in ru-RU
Добавлен callout в документацию Inline Edit про использование
kbqDisableLegacyValidationDirectiveProviderвнутри форм.Когда Inline Edit находится внутри
FormGroup,KbqValidateDirectiveждёт сабмита формы для запуска валидации. Из-за этого компонент никогда не становится невалидным и пользователь не видит ошибок. ДобавлениеkbqDisableLegacyValidationDirectiveProviderв провайдеры отключает это поведение и валидация работает как ожидается.