fix(link): multiline hit area gap, underline (#DS-3562, #DS-4778)#1418
fix(link): multiline hit area gap, underline (#DS-3562, #DS-4778)#1418artembelik merged 8 commits intomainfrom
Conversation
|
Visit the preview URL for this PR (updated for commit d10878d): https://koobiq-next--prs-1418-7kfx2d3h.web.app (expires Tue, 24 Mar 2026 09:28:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
c4808bd to
2eab07f
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
There was a problem hiding this comment.
Pull request overview
This PR updates the Link component styling to better support multi-line links (hit-area + underline rendering), refreshes the multi-line link docs example to include icons/external styling, and adds the missing dark-theme toast screenshot used by Playwright visual tests.
Changes:
- Link styling: add multi-line hit-area padding and switch underline rendering from
border-bottomtotext-decoration(with tokenized thickness/offset). - Docs example: update “link multi-line” example markup and include icon support.
- Testing assets: add
packages/components/toast/__screenshots__/01-dark.pngfor dark-theme visual regression.
Reviewed changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/docs-examples/components/link/link-multi-line/link-multi-line-example.ts | Updates the multi-line link example to use icons/external styling and new layout styling. |
| packages/components/toast/screenshots/01-dark.png | Adds the missing dark-mode baseline screenshot for toast Playwright tests. |
| packages/components/link/link-tokens.scss | Introduces new CSS tokens for multi-line hit-area gap and underline thickness. |
| packages/components/link/_link-theme.scss | Implements multi-line padding/box-decoration handling and migrates underline styling to text-decoration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
packages/docs-examples/components/link/link-multi-line/link-multi-line-example.ts
Outdated
Show resolved
Hide resolved
packages/docs-examples/components/link/link-multi-line/link-multi-line-example.ts
Show resolved
Hide resolved
|
Вижу, что clamped list изменился, нужны ли исправления верстки? |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
No description provided.