Skip to content

fix(link): multiline hit area gap, underline (#DS-3562, #DS-4778)#1418

Merged
artembelik merged 8 commits intomainfrom
fix/DS-3562
Mar 19, 2026
Merged

fix(link): multiline hit area gap, underline (#DS-3562, #DS-4778)#1418
artembelik merged 8 commits intomainfrom
fix/DS-3562

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik self-assigned this Mar 12, 2026
@artembelik artembelik added the bug Something isn't working label Mar 12, 2026
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Visit the preview URL for this PR (updated for commit d10878d):

https://koobiq-next--prs-1418-7kfx2d3h.web.app

(expires Tue, 24 Mar 2026 09:28:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik force-pushed the fix/DS-3562 branch 7 times, most recently from c4808bd to 2eab07f Compare March 12, 2026 11:21
@artembelik artembelik changed the title fix(link): multiline hit area gap (#DS-3562) fix(link): multiline hit area gap (#DS-3562, DS-4778) Mar 16, 2026
@artembelik artembelik changed the title fix(link): multiline hit area gap (#DS-3562, DS-4778) fix(link): multiline hit area gap (#DS-3562, #DS-4778) Mar 16, 2026
@github-actions
Copy link

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@artembelik
Copy link
Contributor Author

/approve-snapshots

@github-actions
Copy link

🔄 Updating snapshots.

@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@koobiq koobiq deleted a comment from github-actions bot Mar 16, 2026
@github-actions
Copy link

✅ Snapshots updated!

@artembelik artembelik requested a review from rmnturov March 16, 2026 14:31
@artembelik artembelik marked this pull request as ready for review March 16, 2026 14:31
@artembelik artembelik requested a review from lskramarov as a code owner March 16, 2026 14:31
Copilot AI review requested due to automatic review settings March 16, 2026 14:31
@artembelik artembelik changed the title fix(link): multiline hit area gap (#DS-3562, #DS-4778) fix(link): multiline hit area gap, underline (#DS-3562, #DS-4778) Mar 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Link component styling to better support multi-line links (hit-area + underline rendering), refreshes the multi-line link docs example to include icons/external styling, and adds the missing dark-theme toast screenshot used by Playwright visual tests.

Changes:

  • Link styling: add multi-line hit-area padding and switch underline rendering from border-bottom to text-decoration (with tokenized thickness/offset).
  • Docs example: update “link multi-line” example markup and include icon support.
  • Testing assets: add packages/components/toast/__screenshots__/01-dark.png for dark-theme visual regression.

Reviewed changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated 4 comments.

File Description
packages/docs-examples/components/link/link-multi-line/link-multi-line-example.ts Updates the multi-line link example to use icons/external styling and new layout styling.
packages/components/toast/screenshots/01-dark.png Adds the missing dark-mode baseline screenshot for toast Playwright tests.
packages/components/link/link-tokens.scss Introduces new CSS tokens for multi-line hit-area gap and underline thickness.
packages/components/link/_link-theme.scss Implements multi-line padding/box-decoration handling and migrates underline styling to text-decoration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@NikGurev
Copy link
Contributor

Вижу, что clamped list изменился, нужны ли исправления верстки?

@github-actions
Copy link

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@artembelik
Copy link
Contributor Author

/approve-snapshots

@github-actions
Copy link

🔄 Updating snapshots.

@github-actions
Copy link

✅ Snapshots updated!

@artembelik artembelik merged commit 50f181f into main Mar 19, 2026
8 checks passed
@artembelik artembelik deleted the fix/DS-3562 branch March 19, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants