KDS-547: Tokenization of Python scripting – Temporary Values Panel #39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| import { type Ref, onMounted, onUnmounted, ref } from "vue"; | ||
| import { useDebounceFn, useResizeObserver } from "@vueuse/core"; | ||
|
|
||
| import { KdsButton } from "@knime/kds-components"; | ||
|
|
||
| import { | ||
| getPythonInitialData, | ||
|
|
@@ -18,11 +18,13 @@ import PythonWorkspaceHeader, { | |
| const resizeContainer = ref<HTMLElement | null>(null); | ||
| const totalWidth: Ref<number> = ref(0); | ||
| const headerWidths = ref<ColumnSizes>([100, 100, 100]); | ||
| // TODO KDS-690: Replace it once the JS tokens are available | ||
| const tableSidePadding = 8; | ||
|
|
||
| const useTotalWidth = () => { | ||
| const rootResizeCallback = useDebounceFn((entries) => { | ||
| const rect = entries[0].contentRect; | ||
| totalWidth.value = rect.width - tableSidePadding * 2; | ||
| }); | ||
| const resizeObserver = useResizeObserver(resizeContainer, rootResizeCallback); | ||
|
|
||
|
|
@@ -75,15 +77,16 @@ onMounted(() => { | |
| </table> | ||
| </div> | ||
| <div class="controls"> | ||
| <KdsButton | ||
| class="reset-button" | ||
| label="Reset Values" | ||
| leading-icon="reset-all" | ||
| variant="transparent" | ||
| :disabled="!resetButtonEnabled" | ||
| @click="resetWorkspace" | ||
| > | ||
| Reset values | ||
|
There was a problem hiding this comment. The button text 'Reset values' is duplicated between the 'label' prop (line 80) and the slot content. Remove the slot content since the label prop already provides the button text.
Contributor
There was a problem hiding this comment. No slots in KdsButtons anymore! |
||
| </KdsButton> | ||
| </div> | ||
| </div> | ||
| </template> | ||
|
|
@@ -94,25 +97,24 @@ onMounted(() => { | |
| flex-direction: column; | ||
| justify-content: space-between; | ||
| height: 100%; | ||
| } | ||
|
|
||
| .workspace { | ||
| --controls-height: 40px; | ||
|
|
||
| position: relative; | ||
| min-width: 120px; | ||
|
|
||
| /* padding to match tableSidePadding in script */ | ||
| padding: var(--kds-spacing-container-0-5x) var(--kds-spacing-container-0-5x) 0 | ||
| var(--kds-spacing-container-0-5x); | ||
| margin-top: 0; | ||
| overflow: hidden auto; | ||
|
|
||
| & table { | ||
| flex: 1; | ||
| max-width: 100%; | ||
| height: calc(100% - var(--controls-height)); | ||
| border-collapse: collapse; | ||
| } | ||
| } | ||
|
|
@@ -121,17 +123,11 @@ onMounted(() => { | |
| display: flex; | ||
| flex-direction: row-reverse; | ||
| place-content: center space-between; | ||
| align-items: center; | ||
| height: var(--kds-dimension-component-height-2-25x); | ||
| padding-right: var(--kds-spacing-container-0-25x); | ||
| padding-left: var(--kds-spacing-container-0-25x); | ||
| overflow: hidden; | ||
| border-top: var(--kds-border-base-subtle); | ||
| } | ||
| </style> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded magic number
8should be documented to explain how it corresponds to the CSS padding value. The comment mentions JS tokens will replace this, but it's unclear how this value relates tovar(--kds-spacing-container-0-5x)used in the CSS.