Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the “Bring Your Own Token” (BYOT) experience for GitHub-powered features by replacing the prior tooltip-style token hint with an interactive info panel and adding a confirmation step before token deletion.
Changes:
- Replaced the GitHub token hint tooltip with a toggleable info panel that shows different copy for “missing” vs “present” token states.
- Added a confirmation modal flow before removing a saved GitHub token (reusing the existing confirm dialog helper).
- Updated Playwright coverage to validate the info panel states and the token deletion confirmation behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/styles/ai-controls.css | Adds styling for the new token info button + popover panel and responsive behavior updates for compact viewports. |
| src/modules/github-byot-controls.js | Syncs token state into DOM (dataset + labels) and adds an onTokenDeleteRequest hook to support confirmation. |
| src/index.html | Replaces tooltip attributes/classes with a dedicated token info panel containing state-specific messaging. |
| src/app.js | Implements token info panel open/close behavior and introduces a generic confirmAction used for token deletion confirmation. |
| playwright/app.spec.ts | Adds tests for token info panel content/state and confirmation requirement for token deletion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.