Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ require (
k8s.io/client-go v0.35.2
k8s.io/code-generator v0.35.2
knative.dev/caching v0.0.0-20260303015151-ff2668f65724
knative.dev/eventing v0.48.1-0.20260304104053-26b9071e4ef3
knative.dev/eventing v0.48.1-0.20260305172655-d9ba4018408f
knative.dev/hack v0.0.0-20260212092700-0126b283bf20
knative.dev/pkg v0.0.0-20260304131155-a902bbfa38de
knative.dev/reconciler-test v0.0.0-20260303022055-b6439c2a1955
knative.dev/serving v0.48.1-0.20260304122354-f161c41d3df3
knative.dev/serving v0.48.1-0.20260305234456-cff52112997b
sigs.k8s.io/yaml v1.6.0
)

Expand Down Expand Up @@ -162,7 +162,7 @@ require (
k8s.io/klog/v2 v2.130.1 // indirect
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect
k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 // indirect
knative.dev/networking v0.0.0-20260223015858-080d52fcffb4 // indirect
knative.dev/networking v0.0.0-20260303015753-965e7c322093 // indirect
sigs.k8s.io/controller-runtime v0.19.0 // indirect
sigs.k8s.io/gateway-api v1.1.0 // indirect
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
Expand Down
12 changes: 6 additions & 6 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1716,18 +1716,18 @@ k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 h1:SjGebBtkBqHFOli+05xYbK8YF1Dzk
k8s.io/utils v0.0.0-20251002143259-bc988d571ff4/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
knative.dev/caching v0.0.0-20260303015151-ff2668f65724 h1:ZrQxBxUCVFb+QrUCR6+hVHjwKtyW8ZyXpIkIYi2Cgdc=
knative.dev/caching v0.0.0-20260303015151-ff2668f65724/go.mod h1:NlTx/oxLKjMnMjoHbE4OtlPkHMu9IVdSl7eJCmXhUiI=
knative.dev/eventing v0.48.1-0.20260304104053-26b9071e4ef3 h1:wujjcmDVnCMkpwZaG2ybXjSjOf57jBf2+x84ChvNY+c=
knative.dev/eventing v0.48.1-0.20260304104053-26b9071e4ef3/go.mod h1:HseSdM0vR//gaW5g0+iU1ApPJZ1mInL+A7DD8kef1sU=
knative.dev/eventing v0.48.1-0.20260305172655-d9ba4018408f h1:ekZyAqGBSmtc1+PkBYWphpKweKO2VeJcn3EdNgg6NjY=
knative.dev/eventing v0.48.1-0.20260305172655-d9ba4018408f/go.mod h1:HseSdM0vR//gaW5g0+iU1ApPJZ1mInL+A7DD8kef1sU=
knative.dev/hack v0.0.0-20260212092700-0126b283bf20 h1:Ocya6ILPQxGrozD5gPELC4J2ASnqvTLvYGJjddKr4Fs=
knative.dev/hack v0.0.0-20260212092700-0126b283bf20/go.mod h1:L5RzHgbvam0u8QFHfzCX6MKxu/a/gIGEdaRBqNiVbl0=
knative.dev/networking v0.0.0-20260223015858-080d52fcffb4 h1:ZXE3pdtSPB0quCfAFUodFT+VsT2Xaoqdj4r//O+zk18=
knative.dev/networking v0.0.0-20260223015858-080d52fcffb4/go.mod h1:ITVa/pZZpgmev4E64KDICg9ZC87YLulpF4J8iMgons4=
knative.dev/networking v0.0.0-20260303015753-965e7c322093 h1:s+HccZPL2A5cBb2FU5CUQ8qJ54LQN5oYK1vtcy94W+M=
knative.dev/networking v0.0.0-20260303015753-965e7c322093/go.mod h1:cIMr1+bAKHFzpou2kVBb82skixqeheSC9heFVc/s1r8=
knative.dev/pkg v0.0.0-20260304131155-a902bbfa38de h1:cz1QT/L7SNC+dF47xYRPJt1WRP/HfTx8+KoZjmGA8V8=
knative.dev/pkg v0.0.0-20260304131155-a902bbfa38de/go.mod h1:mV8s7Uc92am8byZSJPIaVm1NBr0h8vsFL+sEEvMoBbk=
knative.dev/reconciler-test v0.0.0-20260303022055-b6439c2a1955 h1:1SRnHx9BimeT4rIYUA91kjgllqEe7F3VPNdB3ak+kog=
knative.dev/reconciler-test v0.0.0-20260303022055-b6439c2a1955/go.mod h1:WQUf92QsHOho5etxhuSpa7t8SziOhBhXUsg4jRSb1l4=
knative.dev/serving v0.48.1-0.20260304122354-f161c41d3df3 h1:bDZ+w8ULeTMotPmBvppuFYyXFLOkuMpP3yUPIKCMm70=
knative.dev/serving v0.48.1-0.20260304122354-f161c41d3df3/go.mod h1:5EbHL9BqS4wVEXINAc7oSrQojcDh9i6tEiACyEApiLM=
knative.dev/serving v0.48.1-0.20260305234456-cff52112997b h1:AX49lezVEM+jGnK6VH4LfkNPt1fJ2mWuYDd/kF/GWNo=
knative.dev/serving v0.48.1-0.20260305234456-cff52112997b/go.mod h1:wz8mxjdRIUcWVnOUwJzuVHKhrb5IxTeIFHnXljMzS9o=
nhooyr.io/websocket v1.8.6/go.mod h1:B70DZP8IakI65RVQ51MsWP/8jndNma26DVA/nFSCgW0=
pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
pgregory.net/rapid v1.1.0/go.mod h1:PY5XlDGj0+V1FCq0o192FdRhpKHGTRIWBgqjDBTrq04=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,13 @@ func (s *ApiServerSourceStatus) PropagateDeploymentAvailability(d *appsv1.Deploy
if cond.Type == appsv1.DeploymentAvailable {
deploymentAvailableFound = true
if cond.Status == corev1.ConditionTrue {
apiserverCondSet.Manage(s).MarkTrue(ApiServerConditionDeployed)
// Also check that there are no unavailable replicas to ensure the deployment
// is fully ready (not in the middle of a rolling update)
if d.Status.UnavailableReplicas == 0 {
apiserverCondSet.Manage(s).MarkTrue(ApiServerConditionDeployed)
} else {
apiserverCondSet.Manage(s).MarkUnknown(ApiServerConditionDeployed, "DeploymentUpdating", "Deployment has %d unavailable replica(s).", d.Status.UnavailableReplicas)
}
} else if cond.Status == corev1.ConditionFalse {
apiserverCondSet.Manage(s).MarkFalse(ApiServerConditionDeployed, cond.Reason, cond.Message)
} else if cond.Status == corev1.ConditionUnknown {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,13 @@ func (s *PingSourceStatus) PropagateDeploymentAvailability(d *appsv1.Deployment)
if cond.Type == appsv1.DeploymentAvailable {
deploymentAvailableFound = true
if cond.Status == corev1.ConditionTrue {
PingSourceCondSet.Manage(s).MarkTrue(PingSourceConditionDeployed)
// Also check that there are no unavailable replicas to ensure the deployment
// is fully ready (not in the middle of a rolling update)
if d.Status.UnavailableReplicas == 0 {
PingSourceCondSet.Manage(s).MarkTrue(PingSourceConditionDeployed)
} else {
PingSourceCondSet.Manage(s).MarkUnknown(PingSourceConditionDeployed, "DeploymentUpdating", "Deployment has %d unavailable replica(s).", d.Status.UnavailableReplicas)
}
} else if cond.Status == corev1.ConditionFalse {
PingSourceCondSet.Manage(s).MarkFalse(PingSourceConditionDeployed, cond.Reason, cond.Message)
} else if cond.Status == corev1.ConditionUnknown {
Expand Down
6 changes: 3 additions & 3 deletions vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1508,7 +1508,7 @@ k8s.io/utils/trace
## explicit; go 1.25.0
knative.dev/caching/pkg/apis/caching
knative.dev/caching/pkg/apis/caching/v1alpha1
# knative.dev/eventing v0.48.1-0.20260304104053-26b9071e4ef3
# knative.dev/eventing v0.48.1-0.20260305172655-d9ba4018408f
## explicit; go 1.24.0
knative.dev/eventing/cmd/heartbeats
knative.dev/eventing/pkg/apis
Expand Down Expand Up @@ -1604,7 +1604,7 @@ knative.dev/eventing/test/upgrade/prober/wathola/sender
# knative.dev/hack v0.0.0-20260212092700-0126b283bf20
## explicit; go 1.24
knative.dev/hack
# knative.dev/networking v0.0.0-20260223015858-080d52fcffb4
# knative.dev/networking v0.0.0-20260303015753-965e7c322093
## explicit; go 1.25.0
knative.dev/networking/pkg/apis/networking
knative.dev/networking/pkg/apis/networking/v1alpha1
Expand Down Expand Up @@ -1736,7 +1736,7 @@ knative.dev/reconciler-test/pkg/resources/service
knative.dev/reconciler-test/pkg/resources/serviceaccount
knative.dev/reconciler-test/pkg/state
knative.dev/reconciler-test/resources/certificate
# knative.dev/serving v0.48.1-0.20260304122354-f161c41d3df3
# knative.dev/serving v0.48.1-0.20260305234456-cff52112997b
## explicit; go 1.25.0
knative.dev/serving/pkg/apis/autoscaling
knative.dev/serving/pkg/apis/autoscaling/v1alpha1
Expand Down
Loading