Skip to content

fix(mcp): block build --push in read-only MCP mode #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ankitsinghsisodya wants to merge 1 commit into from
+4 −0
Closed

fix(mcp): block build --push in read-only MCP mode #3741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/mcp/tools_build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
}

func (s *Server) buildHandler(ctx context.Context, r *mcp.CallToolRequest, input BuildInput) (result *mcp.CallToolResult, output BuildOutput, err error) {
if s.readonly && input.Push != nil && *input.Push {

Check failure on line 23 in pkg/mcp/tools_build.go

View workflow job for this annotation

GitHub Actions / Precheck 

invalid operation: s.readonly && input.Push != nil (mismatched types "sync/atomic".Bool and untyped bool) (typecheck)

Check failure on line 23 in pkg/mcp/tools_build.go

View workflow job for this annotation

GitHub Actions / verify / Verify Deps and Codegen 

invalid operation: s.readonly && input.Push != nil (mismatched types "sync/atomic".Bool and untyped bool)

Check failure on line 23 in pkg/mcp/tools_build.go

View workflow job for this annotation

GitHub Actions / analyze / Go vulnerability Detection 

invalid operation: s.readonly && input.Push != nil (mismatched types "sync/atomic".Bool and untyped bool)

Check failure on line 23 in pkg/mcp/tools_build.go

View workflow job for this annotation

GitHub Actions / analyze / Analyze CodeQL 

invalid operation: s.readonly && input.Push != nil (mismatched types "sync/atomic".Bool and untyped bool)

Check failure on line 23 in pkg/mcp/tools_build.go

View workflow job for this annotation

GitHub Actions / style / Golang / Lint 

invalid operation: s.readonly && input.Push != nil (mismatched types "sync/atomic".Bool and untyped bool) (typecheck)
err = fmt.Errorf("the server is in read-only mode; set FUNC_ENABLE_MCP_WRITE=true to push images")
Comment on lines +23 to +24
Comment on lines +23 to +24
return
}
out, err := s.executor.Execute(ctx, "build", input.Args()...)
if err != nil {
err = fmt.Errorf("%w\n%s", err, string(out))
Expand Down
Loading