-
Notifications
You must be signed in to change notification settings - Fork 176
docs: Add release note and docs to credentials refactoring #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…07278284864001 docs: Add release note and docs to credentials refactoring
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orbaps The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
Welcome @orbaps! It looks like this is your first PR to knative/func 🎉 |
|
Hi @orbaps. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hey @orbaps thanks for the contribution, can you please sign the CLA so the job can pass |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
- Coverage 55.57% 53.25% -2.32%
==========================================
Files 173 173
Lines 20061 20090 +29
==========================================
- Hits 11148 10699 -449
- Misses 7795 8358 +563
+ Partials 1118 1033 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
Changes
Document usage of FUNC_USERNAME, FUNC_PASSWORD, and FUNC_TOKEN environment variables in func deploy help text
Document usage of FUNC_USERNAME, FUNC_PASSWORD, and FUNC_TOKEN environment variables in func build help text
Update generated reference documentation for deploy and build commands
/kind documentation
Fixes #3299
Release Note
The FUNC_USERNAME and FUNC_PASSWORD environment variables (and FUNC_TOKEN) now work for registry authentication in
func deployandfunc buildcommands across different pushers.Docs