Skip to content

Conversation

@orbaps
Copy link

@orbaps orbaps commented Jan 21, 2026

Changes

Changes
Document usage of FUNC_USERNAME, FUNC_PASSWORD, and FUNC_TOKEN environment variables in func deploy help text
Document usage of FUNC_USERNAME, FUNC_PASSWORD, and FUNC_TOKEN environment variables in func build help text
Update generated reference documentation for deploy and build commands
/kind documentation

Fixes #3299

Release Note

The FUNC_USERNAME and FUNC_PASSWORD environment variables (and FUNC_TOKEN) now work for registry authentication in func deploy and func build commands across different pushers.
Docs

@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: orbaps
Once this PR has been reviewed and has the lgtm label, please assign linkvt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

CLA Not Signed

@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

Welcome @orbaps! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

Hi @orbaps. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor

gauron99 commented Feb 2, 2026

hey @orbaps thanks for the contribution, can you please sign the CLA so the job can pass

@gauron99
Copy link
Contributor

gauron99 commented Feb 2, 2026

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.25%. Comparing base (66d2f4c) to head (f2e14ee).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3382      +/-   ##
==========================================
- Coverage   55.57%   53.25%   -2.32%     
==========================================
  Files         173      173              
  Lines       20061    20090      +29     
==========================================
- Hits        11148    10699     -449     
- Misses       7795     8358     +563     
+ Partials     1118     1033      -85     
Flag Coverage Δ
e2e 39.74% <100.00%> (+0.03%) ⬆️
e2e go 35.54% <100.00%> (+0.04%) ⬆️
e2e node 31.31% <100.00%> (+0.04%) ⬆️
e2e python 35.04% <100.00%> (+0.04%) ⬆️
e2e quarkus 31.44% <100.00%> (+0.02%) ⬆️
e2e rust 30.86% <100.00%> (+0.02%) ⬆️
e2e springboot 29.34% <100.00%> (+0.05%) ⬆️
e2e typescript 31.45% <100.00%> (+0.06%) ⬆️
integration ?
unit macos-14 44.80% <100.00%> (-0.08%) ⬇️
unit macos-latest 44.80% <100.00%> (-0.08%) ⬇️
unit ubuntu-24.04-arm 44.92% <100.00%> (-0.05%) ⬇️
unit ubuntu-latest 45.70% <100.00%> (-0.08%) ⬇️
unit windows-latest 44.83% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add release note and docs to credentials refactoring.

2 participants