Fix undefined method calls in Symfony 8#53
Closed
brpauwels wants to merge 1 commit into
Closed
Conversation
brpauwels
commented
Mar 17, 2026
``` Call to undefined method Symfony\Component\HttpFoundation\Request::get() ```
klapaudius
reviewed
Mar 17, 2026
Owner
There was a problem hiding this comment.
Hello @brpauwels, thank you for your PR.
This fix is too restrictive,
Symfony 7.4 deprecated Request::get() method has this code :
public function get(string $key, mixed $default = null): mixed
{
trigger_deprecation('symfony/http-foundation', '7.4', 'Request::get() is deprecated, use properties ->attributes, query or request directly instead.');
if ($this !== $result = $this->attributes->get($key, $this)) {
return $result;
}
if ($this->query->has($key)) {
return $this->query->all()[$key];
}
if ($this->request->has($key)) {
return $this->request->all()[$key];
}
return $default;
}
We need to do the same.
klapaudius
pushed a commit
that referenced
this pull request
Mar 17, 2026
Owner
|
I did the change to have the same behavior as Symfony 7.4. Thank you for your feedback. I draft the new release now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.