fix test cases 22e 30c 30d 30e 30f#269
Open
jduchateau wants to merge 2 commits intokg-construct:mainfrom
Open
Conversation
jduchateau
force-pushed
the
fix-RMLTC0022e-JSON
branch
from
25d302a to
f4eefd9
Compare
jduchateau
changed the title
Member
Author
|
@dachafra @eiglesias34 I found some issues in the new set of test cases; this should fix them. |
eiglesias34
reviewed
Mar 31, 2026
Contributor
eiglesias34
left a comment
eiglesias34
left a comment
There was a problem hiding this comment.
Thank you for noticing the missing triples. The ones added are correct.
eiglesias34
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test cases introduced in #261.
RMLTC0022e-JSON: JSONPath not starting with
$.and 30cdef seems to not have the right expected output.
RMLTC0030c-JSON: if parentMap (sports) is constant 100, we generate all sports for student having said sport 100
RMLTC0030d-JSON: idem with template
RMLTC0030e-JSON: if childMap (students) is constant 100, we generate Tennis (sport 100) for all students.
RMLTC0030f-JSON: idem with template