feat:playwright tests for tree-details page#1719
Open
WilsonNet wants to merge 2 commits intokernelci:mainfrom
Open
feat:playwright tests for tree-details page#1719WilsonNet wants to merge 2 commits intokernelci:mainfrom
WilsonNet wants to merge 2 commits intokernelci:mainfrom
Conversation
WilsonNet
changed the title
MarceloRobert
added
the
CI/CD
WilsonNet
force-pushed
the
feat/playwright-tree-details
branch
from
b56be97 to
9efbd26
Compare
WilsonNet
changed the title
WilsonNet
force-pushed
the
feat/playwright-tree-details
branch
3 times, most recently
from
dc5aadb to
9948da4
Compare
WilsonNet
commented
Feb 4, 2026
| data-test-id="breadcrumb-trees-link" | ||
| > | ||
| <FormattedMessage id="tree.details" /> | ||
| <FormattedMessage id="tree.path" /> |
Collaborator
Author
There was a problem hiding this comment.
please remove this change
WilsonNet
commented
Feb 4, 2026
WilsonNet
commented
Feb 5, 2026
WilsonNet
force-pushed
the
feat/playwright-tree-details
branch
from
2677116 to
8623ee8
Compare
Add comprehensive e2e tests covering all requirements from issue kernelci#1664: - Filter drawer interaction (open/close/apply) - Filter selection via drawer (FAIL status filter) - Filter selection via summary cards (architecture links) - URL parameter validation after filter application Implement type-safe test ID system using Zod validation: - Add ColumnMetaSchema for validating table column metadata - Pass dataTestId through column meta instead of hardcoded checks - Add data-test-id props to TreeBreadcrumb and StatusChart components All components remain generic without business-specific logic. Closes kernelci#1664
Add two skills to guide AI coding agents working on the codebase: - typescript-type-safety: Enforces runtime validation with Zod or type guards instead of unsafe type assertions - react-generic-components: Ensures components remain generic and reusable without hardcoded business logic These skills provide guidelines, examples, and decision trees for maintaining code quality and consistency across the monorepo.
WilsonNet
force-pushed
the
feat/playwright-tree-details
branch
from
8623ee8 to
ff1381e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end tests for tree details filter functionality, covering all requirements from issue #1664. Implements a type-safe test ID system using Zod validation while maintaining generic component architecture.
Additionally, adds AI agent skills to guide future code contributions with TypeScript and React best practices.
Changes
E2E Tests (Issue #1664)
New filter tests: 2 comprehensive tests for filter functionality
Test infrastructure improvements:
e2e/selectors/directory with common patternse2e/utils/(navigation, filters)AI Agent Skills (
.agents/skills/)Added two skills for maintaining code quality:
How to Test
Prerequisites
Start dev server with staging API proxy (in tmux or separate terminal):
cd dashboard pnpm run dev-remote-apiThe dev server should start on
http://localhost:5173with proxy configured for/staging-apiRun Tests
Run all tests:
cd dashboard pnpm run e2eRun only tree details tests:
Run only filter tests:
pnpm run e2e -- tree-details.spec.ts -g "adds filters"Run with UI mode (interactive):
Manual Testing
Navigate to http://localhost:5173/tree/android/android-mainline/7c5912a7c78d669e825093b8cbb57e6afaa88d11
Test filter drawer:
df.*FAIL)Test summary card filters:
Test breadcrumb navigation:
Technical Details
Closes #1664