Propagate conventions to all agents and add new rules from PR reviews#786
Open
kelos-bot[bot] wants to merge 2 commits intomainfrom
Open
Propagate conventions to all agents and add new rules from PR reviews#786kelos-bot[bot] wants to merge 2 commits intomainfrom
kelos-bot[bot] wants to merge 2 commits intomainfrom
Conversation
github-actions
bot
added
needs-triage
needs-kind
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
kelos-bot
bot
changed the title
kelos-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2026
Add three new agent conventions from recent PR review feedback: 1. Per-TaskSpawner configuration should be CRD fields, not controller flags (PR #838 - gjkim42 review) 2. CRD API backward compatibility - never rename JSON field tags (PR #838 - P1 review finding) 3. Gate optional CRDs behind Helm values flags (PR #821 - PodMonitoring broke installs on clusters without monitoring.googleapis.com) Also includes previously proposed conventions from PR #786: - Consistent guidance across surfaces - Provider-agnostic API design - Idiomatic Helm values - Deploy-dev workflow sync - Controller-driven migration - Release note user action requirements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
bcdeef3 to
7ade17e
Compare
kelos-bot
bot
changed the title
Collaborator
|
/kelos pick-up |
Author
|
🤖 Kelos Task Status Task |
kelos-bot
bot
added
kind/cleanup
and removed
needs-kind
Author
|
🤖 Kelos Agent @gjkim42 /kelos needs-input Rebased on origin/main (was already up to date). Added The only failing CI check is Ready for re-review. |
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
7ade17e to
782ce1c
Compare
kelos-bot
bot
changed the title
kelos-bot
bot
changed the title
kelos-bot
bot
changed the title
Add four new conventions backed by review evidence from recent PRs: 1. Go template variable completeness: initialize all template variables unconditionally, not just inside conditional branches (PR #866) 2. Nil-safe chained accessor calls: check intermediate pointers for nil when using go-github event types (PR #851) 3. Consistent string comparison strategy: do not mix EqualFold and == for the same field across code paths (PRs #866, #880) 4. Helm nil-safe nested value access: use dig or hasKey/default for nested values that may not exist (PR #866) Also sync kelos-workers-agent conventions with kelos-dev-agent (missing 11 conventions including K8s comparison, CRD backward compat, Docker image pinning, Go safety rules, and RBAC), and expand the reviewer agent checklist with Helm/CRD, Security, and Go convention sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
0871329 to
6379545
Compare
kelos-bot
bot
changed the title
…oop state reset rules Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates agent configuration based on lessons learned from recent PR reviews. Two categories of changes:
1. Propagate existing conventions to all agent configs
Several conventions existed only in
kelos-workers.yamlbut were missing fromCLAUDE.md,AGENTS.md, andagentconfig.yaml. This meant non-worker agents (dev agent, PR responder) didn't know about them, causing recurring violations:time.Sleep)time.Sleep(50ms)flagged in concurrent tests across multiple PRsdelete/patchverbs on Servicest.Fatalin goroutines)2. Two new conventions backed by review evidence
http.DefaultClient; always create a client with explicitTimeouthttp.DefaultClient.Do(req)inlinear_api.goas blocking indefinitely if Linear API hangsGenericEventData.Fieldsmap leaked stale entries from Spawner A to Spawner B across loop iterationsFiles changed:
CLAUDE.md/AGENTS.md— added 7 conventions (5 propagated + 2 new)self-development/agentconfig.yaml— added same 7 conventions to shared agent configself-development/kelos-workers.yaml— added 2 new conventions (HTTP client timeout, loop state reset)self-development/kelos-reviewer.yaml— added HTTP client timeout and loop state reset to reviewer checklistWhich issue(s) this PR is related to:
N/A
Special notes for your reviewer:
The propagation is the most impactful change — it closes the gap between what the reviewer agent checks for and what the other agents (dev, PR responder) know to avoid. The two new conventions are net-new patterns identified from PR #866 and #902 reviews this week.
Does this PR introduce a user-facing change?