fix(service-client): fix editor service internal URL#488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/keboola/issue/AJDA-2605
Description
The internal Kubernetes URL for the editor service was wrong. The actual k8s service is named
editor-service-apiin theeditor-servicenamespace, but the code referencededitor-api.editor-service. https://github.com/keboola/kbc-stacks/blob/main/apps/editor-service/templates/deployment-api.yaml#L4Release Notes
Change Type
Bug fix.
Justification
The wrong internal URL would cause requests to the editor service to fail in any context using
ServiceDnsType::INTERNAL.Plans for Customer Communication
No customer-facing change.
Impact Analysis
Low risk. Only affects internal service-to-service communication targeting the editor service. No breaking changes, no feature flags.
Deployment Plan
Standard CI/CD continuous deployment across all stacks.
Rollback Plan
Standard git revert if issues detected post-deployment.
Post-Release Support Plan
No follow-up actions needed.