Skip to content

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Jan 26, 2026

Summary

This PR adds the first e2e tests for the init-agent, ensuring the basic functionality.

I also included a fix for the multicluster code: It was accidentally using the kcp kubeconfig, i.e. it was creating new objects inside new workspaces using the /clusters/... endpoint directly (which worked in my local testing becaue I used the admin kubeconfig from kcp). Instead the initcontroller has to use the virtual workspace endpoint (/services/initws/clusters/....). Since this URL is not available to the initcontroller (the multicluster provider has no way to pass it down to the controllers), all the controller has is mgr.GetCluster().GetClient().

So to solve this, there is no longer a ClusterApplier, and the applier itself is not containing a client at all anymore. Instead it gets it passed in the Apply() call. This is technically not the abstraction I head in mind for the applier, but alas.

What Type of PR Is This?

/kind feature

Release Notes

NONE

…rtual workspace URL of the initws VW instead

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot
Copy link

@xrstf: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

Details

In response to this:

Summary

This PR adds the first e2e tests for the init-agent, ensuring the basic functionality.

What Type of PR Is This?

/kind feature

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 26, 2026
@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrstf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 26, 2026
xrstf added 2 commits January 26, 2026 16:40
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf xrstf changed the title WIP - Add end-to-end testing Add end-to-end testing Jan 26, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2026
@xrstf xrstf mentioned this pull request Jan 26, 2026
On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants