Add end-to-end testing #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the first e2e tests for the init-agent, ensuring the basic functionality.
I also included a fix for the multicluster code: It was accidentally using the kcp kubeconfig, i.e. it was creating new objects inside new workspaces using the
/clusters/...endpoint directly (which worked in my local testing becaue I used the admin kubeconfig from kcp). Instead the initcontroller has to use the virtual workspace endpoint (/services/initws/clusters/....). Since this URL is not available to the initcontroller (the multicluster provider has no way to pass it down to the controllers), all the controller has ismgr.GetCluster().GetClient().So to solve this, there is no longer a ClusterApplier, and the applier itself is not containing a client at all anymore. Instead it gets it passed in the
Apply()call. This is technically not the abstraction I head in mind for the applier, but alas.What Type of PR Is This?
/kind feature
Release Notes