Merged
Conversation
Signed-off-by: Edwin Hermans <edwin@madtech.cx> Updated using the crds from github Signed-off-by: Edwin Hermans <edwin@madtech.cx>
madeddie
force-pushed
the
capa_update_fix
branch
from
22cf87e to
e0bcd4e
Compare
Contributor
Author
|
As a side-note I used the CRDS from the git repo instead of downloaded from a live cluster this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Please confirm that you have read the document before PR submitted
2. Contact Information(Optional)
If it is convenient, please provide your contact information so we can reach you when processing the PR:
@Peefy I've found a bug in kcl import where when 2 version of CRDS are identical only 1 is included (this might be by design to deduplicate). In this case the identity CRDS are identical between v1beta1 and v1beta2 except for the version of the parent CRD they depend on. Having only the v1beta1 version available means the use of of the whole v1beta2 parent breaks.