fix: prevent deepStrictObjectKeys from recursing into Date objects#46
Merged
fix: prevent deepStrictObjectKeys from recursing into Date objects#46
Conversation
Date objects are leaf values in the object tree (via ValueType), but the runtime function was treating them as regular objects to traverse, producing keys like "createdAt.toISOString" and "createdAt.getTime". This created a type/runtime mismatch where the type-level DeepStrictObjectKeys correctly treated Date as a leaf, but the runtime function did not. Added instanceof Date guard alongside the existing object type check to ensure consistent behavior with the type-level implementation. Test coverage added for: - Date as nested leaf inside objects - Date properties inside array elements - Multiple Date fields at different nesting depths Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a type/runtime mismatch in
deepStrictObjectKeyswhere the runtime function was incorrectly recursing intoDateobjects, producing keys like"createdAt.toISOString"and"createdAt.getTime". The type-level implementation correctly treatsDateas a leaf value (via theValueTypetype), but the runtime function lacked this guard.Changes
instanceof Datecheck to the object recursion condition indeepStrictObjectKeysCloses
#39
🤖 Generated with Claude Code