fix: add rest.length > 0 guard to deepStrictAssert#41
Merged
Conversation
… error on top-level object properties Matches the fix already present in deepStrictPick. When picking a top-level key whose value is a plain object, the missing guard caused traverse() to be called with an empty keys array, resulting in undefined being used as a key. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rest.length > 0guard todeepStrictAssertto prevent runtime error when picking top-level keys whose values are plain objectsdeepStrictPickTest plan
test_functions_deepStrictAssert_accesses_top_level_object_propertyverifies the fix🤖 Generated with Claude Code