Fix: Rescue OpenSSL::Cipher::CipherError for unsupported cipher algorithms #39
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithms ## Summary Fix error handling in `JWE::Enc::Cipher.for` to properly catch unsupported cipher errors. ## Problem When an unsupported cipher algorithm is used, newer versions of OpenSSL raise `OpenSSL::Cipher::CipherError` instead of `RuntimeError`. This caused 6 test failures because the expected `JWE::NotImplementedError` was not being raised. ## Solution Added `OpenSSL::Cipher::CipherError` to the rescue clause alongside the existing `RuntimeError` to handle both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix error handling in
JWE::Enc::Cipher.forto properly catch unsupported cipher errors.Problem
When an unsupported cipher algorithm is used, newer versions of OpenSSL raise
OpenSSL::Cipher::CipherErrorinstead ofRuntimeError. This caused 6 test failures because the expectedJWE::NotImplementedErrorwas not being raised.Solution
Added
OpenSSL::Cipher::CipherErrorto the rescue clause alongside the existingRuntimeErrorto handle both cases.