Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jvdieten!
Thank you for this little library, we're using it for end-to-end tests in various places where we generate XML files for geospatial analysis.
In this PR, I changed the type signature of the
nextargument to benext: (result: IDiffResultModel[]) => void, to ensure that any function passed as the final argument todiffanddiffAsXmlwill get the correct type information.This shouldn't be a breaking change, and if it is for downstream users, they've probably got a bug anyway...
I was also going to alter the type signature of the functions to return something generic, like:
Then you could use it like so:
However I feel that may be too much of an impact to the API. If you feel this would be valuable, I'd be more than happy to create a seperate pull request for that.
Kind regards,
Wouter