Skip to content

refactor: extract duplicate code in a runner function #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 1 commit into from
Feb 20, 2026
Merged

refactor: extract duplicate code in a runner function #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions src/services/emulator/_runner.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,27 +31,24 @@ import {createDeployTargetDir} from './_fs.services';
export const startContainer = async () => {
await assertAndInitConfig();

const parsedResult = await readEmulatorConfig();

if (!parsedResult.success) {
return;
}

const {config} = parsedResult;

const {valid} =
config.derivedConfig.runner === 'docker' ? await checkDockerVersion() : {valid: true};
const fn: RunWithConfigFn = async (args) => {
await startEmulator(args);
};

if (valid === 'error' || !valid) {
return;
}
await runWithConfig({fn});
};

await assertContainerRunnerRunning({runner: config.derivedConfig.runner});
export const stopContainer = async () => {
const fn: RunWithConfigFn = async (args) => {
await stopEmulator(args);
};

await startEmulator({config});
await runWithConfig({fn});
};

export const stopContainer = async () => {
type RunWithConfigFn = (params: {config: CliEmulatorConfig}) => Promise<void>;

const runWithConfig = async ({fn}: {fn: RunWithConfigFn}) => {
const parsedResult = await readEmulatorConfig();

if (!parsedResult.success) {
Expand All @@ -69,7 +66,7 @@ export const stopContainer = async () => {

await assertContainerRunnerRunning({runner: config.derivedConfig.runner});

await stopEmulator({config});
await fn({config});
};

const promptEmulatorType = async (): Promise<{emulatorType: Exclude<EmulatorType, 'console'>}> => {
Expand Down