Remove backwards-compatible authentication config#537
Remove backwards-compatible authentication config#537ambient-code[bot] wants to merge 1 commit intomainfrom
Conversation
….7.0) Remove the legacy `authentication` configmap key and `authenticationConfig` Helm value that were kept for backwards compatibility with a TODO to remove in 0.7.0. The project is now past v0.8.1, so this cleanup is overdue. Also removes the now-unused `oidc.LoadAuthenticationConfiguration` function and updates documentation to reference the current config approach. Closes #530 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CI Status UpdateThe pytest failure in This PR only modifies:
The failing test is a macOS-specific Python test that validates bash substring syntax in hook execution. This is not touched by any of the authentication config removal changes. The test expects the output Is this a known flaky test on macOS, or should we investigate further? |
Summary
authenticationconfigmap key andauthenticationConfigHelm value that were kept for backwards compatibility, with TODO comments saying "remove in 0.7.0"oidc.LoadAuthenticationConfigurationfunction and its helpernewJWTAuthenticator(theconfigpackage has its own equivalent implementations that remain in use)spec.authentication.jwton the Jumpstarter resource instead of the removedjumpstarter-controller.authenticationConfigurationHelm valueTest plan
go build ./...passes in the controller module with no errorsauthenticationConfigvalueconfigkey continue to workCloses #530
🤖 Generated with Claude Code