Skip to content

Remove backwards-compatible authentication config#537

Open
ambient-code[bot] wants to merge 1 commit intomainfrom
ambient-fix/530-remove-auth-compat
Open

Remove backwards-compatible authentication config#537
ambient-code[bot] wants to merge 1 commit intomainfrom
ambient-fix/530-remove-auth-compat

Conversation

@ambient-code
Copy link
Copy Markdown
Contributor

@ambient-code ambient-code bot commented Apr 9, 2026

Summary

  • Remove the legacy authentication configmap key and authenticationConfig Helm value that were kept for backwards compatibility, with TODO comments saying "remove in 0.7.0"
  • Remove the now-unused oidc.LoadAuthenticationConfiguration function and its helper newJWTAuthenticator (the config package has its own equivalent implementations that remain in use)
  • Update Dex documentation to reference spec.authentication.jwt on the Jumpstarter resource instead of the removed jumpstarter-controller.authenticationConfiguration Helm value

Test plan

  • go build ./... passes in the controller module with no errors
  • Verify Helm chart renders correctly without authenticationConfig value
  • Verify existing deployments using the new config key continue to work

Closes #530

🤖 Generated with Claude Code

….7.0)

Remove the legacy `authentication` configmap key and `authenticationConfig`
Helm value that were kept for backwards compatibility with a TODO to remove
in 0.7.0. The project is now past v0.8.1, so this cleanup is overdue.
Also removes the now-unused `oidc.LoadAuthenticationConfiguration` function
and updates documentation to reference the current config approach.

Closes #530

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5af5b6dc-1c3f-4af2-b2f2-ba5b7d4cbfe4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ambient-fix/530-remove-auth-compat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit 892b7bf
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/69d7ccccceb40500089fcc96
😎 Deploy Preview https://deploy-preview-537--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ambient-code
Copy link
Copy Markdown
Contributor Author

ambient-code bot commented Apr 9, 2026

CI Status Update

The pytest failure in jumpstarter/exporter/hooks_test.py::TestHookExecutor::test_exec_bash appears to be unrelated to this PR's changes.

This PR only modifies:

  • Go controller code (config.go, oidc/config.go)
  • Helm templates and values
  • Documentation

The failing test is a macOS-specific Python test that validates bash substring syntax in hook execution. This is not touched by any of the authentication config removal changes.

The test expects the output BASH_OK: world from the bash command V="hello_world"; echo "BASH_OK: ${V:6:5}" but it's not appearing in the mock logger calls on macOS-15 with Python 3.11.

Is this a known flaky test on macOS, or should we investigate further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove backwards-compatible authentication config in 0.7.0

0 participants