Refactor startup promise orchestration#157
Open
Mahathi-s154 wants to merge 2 commits intojoplin:masterfrom
Open
Refactor startup promise orchestration#157Mahathi-s154 wants to merge 2 commits intojoplin:masterfrom
Mahathi-s154 wants to merge 2 commits intojoplin:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors startup async orchestration by removing the custom PromiseGroup abstraction and replacing it with a typed resolveNamedPromises helper, while simplifying other aggregation points to use native Promise.all.
Changes:
- Replace
PromiseGroupwithresolveNamedPromisesfor resolving keyed async dependencies. - Use
Promise.alldirectly for notebook display data aggregation and command registrations. - Add unit tests for
resolveNamedPromisesand ensure toolbar button creation happens after command registration completes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/utils/promises.ts |
Removes PromiseGroup and adds resolveNamedPromises for typed named-promise resolution. |
src/index.ts |
Updates startup logic to use resolveNamedPromises / Promise.all, and awaits command registration before creating toolbar buttons. |
tests/utils/promises.spec.ts |
Adds focused Jest coverage for resolveNamedPromises behavior (resolve/empty/reject). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing