Support nested path for docker build #3330
Open
+173
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluxxBot
added
improvement
fluxxBot
force-pushed
the
dockernested
branch
from
5b91887 to
b0f1a69
Compare
fluxxBot
added
safe to test
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Description:
It was found that uploading docker images inside a nested path caused failure in attaching build properties in the artifacts due to invalid path construction:
eg: docker-repo/myorg/image:latest when uploaded, cli tried to attach properties on docker-repo/image:latest, as a result attaching properties caused 404 not found failure.
Solution:
instead of using image full name which returned image:latest, we are using image full name without repo which returns myorg/image:latest