Upload OIDC discovery data to disco backend #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inteon
force-pushed
the
oidc_upload
branch
5 times, most recently
from
c5cffaf to
c140a0e
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds OIDC discovery data collection and upload functionality to the disco-agent. The agent now gathers OpenID Connect configuration and JWKS (JSON Web Key Set) information from the Kubernetes API server's well-known OIDC endpoints and uploads this data to the CyberArk backend.
Changes:
- Introduced a new OIDC data gatherer that fetches OIDC configuration from
/.well-known/openid-configurationand JWKS from/openid/v1/jwksendpoints - Modified the OIDC data gatherer to return a pointer to
OIDCDiscoveryDatainstead of a value, consistent with other data gatherers - Added OIDC fields to the CyberArk snapshot structure for data upload
- Configured the OIDC gatherer in the default agent deployment templates
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/datagatherer/oidc/oidc.go | Changed return type from value to pointer for consistency with other data gatherers |
| pkg/datagatherer/oidc/oidc_test.go | Updated type assertions to handle pointer type |
| api/datareading.go | Added OIDCDiscoveryData type to the unmarshal priority list |
| pkg/client/client_cyberark.go | Added extractOIDCFromReading function and registered it in defaultExtractorFunctions |
| pkg/client/client_cyberark_test.go | Added OIDC test data with error scenarios |
| internal/cyberark/dataupload/dataupload.go | Added OIDC-related fields to the Snapshot struct |
| examples/machinehub.yaml | Added OIDC gatherer configuration example |
| examples/machinehub/input.json | Added example OIDC data with configuration and JWKS |
| deploy/charts/disco-agent/templates/configmap.yaml | Enabled OIDC gatherer in default configuration |
| deploy/charts/disco-agent/tests/snapshot/configmap_test.yaml.snap | Updated test snapshots to include OIDC gatherer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OIDC discovery data upload functionality to the disco-agent.
The data gatherer itself was added in #758.