Add collapsible control panels with mobile/desktop sizing tweaks#23
Open
jeromepotter wants to merge 1 commit intomainfrom
Open
Add collapsible control panels with mobile/desktop sizing tweaks#23jeromepotter wants to merge 1 commit intomainfrom
jeromepotter wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for les-cercles ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
details/summaryblocks and added a.panel-caretindicator that shows▾when closed and▴when open.summaryand changed header buttons to callstopSummaryToggle(event)to prevent toggling when interacting with controls.stopSummaryToggle(event)in the script topreventDefault()andstopPropagation()for header buttons.@media (min-width: 769px)) that reduces panel padding, font sizes, slider heights, and related spacing to make panels roughly 50% of their previous height.Testing
python -m http.server 8000and ran a Playwright script to loadindex.htmlat a mobile viewport (width: 375, height: 812), which produced a screenshot successfully.Codex Task