Skip to content

Fix broken tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcmosc merged 3 commits into from
Feb 16, 2026
Merged

Fix broken tests #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7322602
Update tests for updated AGTraceType
jcmosc Jan 19, 2026
06bbc0f
Fix HashTable implementation
jcmosc Jan 19, 2026
392819c
Wrap all layout descriptor tests in exit tests
jcmosc Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions Sources/Utilities/HashTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,13 @@ void UntypedTable::grow_buckets() {
if (new_buckets) {
_bucket_mask = num_buckets - 1;
for (uint32_t i = 0; !(i >> old_width); i++) {
for (UntypedTable::HashNode *node = old_buckets[i]; node != nullptr; node = node->next) {
UntypedTable::HashNode *node = old_buckets[i];
while (node != nullptr) {
UntypedTable::HashNode *next = node->next;
uint64_t new_bucket = _bucket_mask & node->hash_value;
node->next = new_buckets[new_bucket];
new_buckets[new_bucket] = node;
node = next;
}
}
_buckets = new_buckets;
Expand Down Expand Up @@ -242,11 +245,16 @@ bool UntypedTable::remove(key_type key) {
return this->remove_ptr(key);
}
uint64_t hash_value = _hash(key);
HashNode *node = _buckets[_bucket_mask & hash_value];
uint64_t bucket = _bucket_mask & hash_value;
HashNode *prev = nullptr;

for (HashNode *candidate = node; candidate != nullptr; candidate = candidate->next) {
for (HashNode *candidate = _buckets[bucket]; candidate != nullptr; candidate = candidate->next) {
if (candidate->hash_value == hash_value && _compare(candidate->key, key)) {
node->next = candidate->next;
if (prev == nullptr) {
_buckets[bucket] = candidate->next;
} else {
prev->next = candidate->next;
}
if (_did_remove_key) {
_did_remove_key(candidate->key);
}
Expand All @@ -258,7 +266,7 @@ bool UntypedTable::remove(key_type key) {
_count -= 1;
return true;
}
node = candidate;
prev = candidate;
}

return false;
Expand All @@ -269,10 +277,16 @@ bool UntypedTable::remove_ptr(key_type key) {
return false;
}

HashNode *node = _buckets[_bucket_mask & _hash(key)];
for (HashNode *candidate = node; candidate != nullptr; candidate = candidate->next) {
uint64_t bucket = _bucket_mask & _hash(key);
HashNode *prev = nullptr;

for (HashNode *candidate = _buckets[bucket]; candidate != nullptr; candidate = candidate->next) {
if (candidate->key == key) {
node->next = candidate->next;
if (prev == nullptr) {
_buckets[bucket] = candidate->next;
} else {
prev->next = candidate->next;
}
if (_did_remove_key) {
_did_remove_key(candidate->key);
}
Expand All @@ -284,7 +298,7 @@ bool UntypedTable::remove_ptr(key_type key) {
_count -= 1;
return true;
}
node = candidate;
prev = candidate;
}
return false;
}
Expand Down
Loading