Cater for end-of-file code blocks, change to format.scrub, added schema processing, handling for comment edge-case, prevent extra empty coverage record from being added to sqlcc.js#14
Open
nickidw wants to merge 6 commits intojbarker7:masterfrom
Conversation
Executed Code blocks at the end of file are not detected due to EndByte = -1, so the coverage is calculated lower than what it should be
stefanteixeira
added a commit
to stefanteixeira/sqlcc
that referenced
this pull request
Jul 3, 2016
Including fix to format.scrub made by nickidw: jbarker7#14
stefanteixeira
added a commit
to stefanteixeira/sqlcc
that referenced
this pull request
Jul 3, 2016
Including fix to format.scrub made by nickidw: jbarker7#14
Added schema processing
nickidw
changed the title
Merged changes from stefanteixeira that allows starting, stopping of traces externally to increase integration ability.
….js array. The schema is stripped off when displaying the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executed Code blocks at the end of file are not detected due to EndByte
= -1, so the coverage is calculated lower than what it should be.
Change to format.scrub to prevent Regex.Replace from hanging.