Changes made to make compatible with react 16#4
Open
timrooke1991 wants to merge 1 commit intojampy:masterfrom
Open
Changes made to make compatible with react 16#4timrooke1991 wants to merge 1 commit intojampy:masterfrom
timrooke1991 wants to merge 1 commit intojampy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the functionality of this package but came across a number of issues when using it in conjunction with React 16. This pull request adds in two dependancies
prop-typesandcreate-react-class, which have now been abstracted away from the core React library as of version 16, and updates instances where these removed functions are relied on in the code.As mentioned, I needed to do this for
react-wakelockto run with React 16 on my own personal project, so thought I'd submit as a pull request in case you wanted to incorporate these changes (I see there this one open issue, #3, which this pull request would solve).