[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12262] Exclude CMAB from UserProfileService#9
Closed
[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12262] Exclude CMAB from UserProfileService#9
Conversation
Excluded CMAB experiments from UserProfileService (UPS) logic for both lookup and save operations. CMAB requires dynamic decisions based on current user attributes and TTL, which contradicts UPS's sticky bucketing behavior that maintains decisions across experiment lifetime. Changes: - Modified decision_service.py to check experiment.cmab before UPS lookup - Modified decision_service.py to check experiment.cmab before UPS save - Added comprehensive unit tests for CMAB UPS exclusion - Added tests verifying non-CMAB experiments still use UPS Quality Assurance Summary: - Iterations: 1/5 (success on first iteration) - Tests: 4 new tests added, all passing (52/52 total tests pass) - Files modified: optimizely/decision_service.py, tests/test_decision_service.py - Code review: Manual review completed - Test coverage: Comprehensive coverage for both CMAB and non-CMAB scenarios Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excluded CMAB experiments from UserProfileService logic to ensure dynamic decision-making. CMAB requires decisions based on current user attributes and TTL, which contradicts UPS's sticky bucketing behavior that maintains decisions across the experiment lifetime without considering these factors.
Changes
Jira Ticket
FSSDK-12262
Testing
Verified with unit tests.